Testing build #215

[rejetto]

download @ www.dovedove.it/hfs/hfs215.exe

what's new
+ support for "x-forwarded-host" www.rejetto.com/forum/?topic=6327
+ network handler improved (some strange old problems may disappear)
+ parameters for {.disconnect.}
+ new template symbols: %item-ip% and %item-port% in [progress-upload-file] and [progress-download-file]
+ %item...% symbols working in event [upload completed] http://www.rejetto.com/forum/index.php?topic=6154.msg1037630#msg1037630
- fixed "x-forwarded-for" support www.rejetto.com/forum/?topic=6292

[Mars]

bug on build 000 to 215

The locked icon on an item disappears when we move this item in another place of the vfs.

It is not a bug of hfs but a dysfunction of the source comctrls.pas, unless having appeal to the canvas to redraw the good icon , I do not see solution

http://www.experts-exchange.com/Programming/Languages/Pascal/Delphi/Q_10015986.html

[Mars]

found this function on the web

function FileDeleteRB(AFileName: string): boolean;
var Struct: TSHFileOpStruct;
    pFromc: array[0..255] of char;
    Resultval: integer;
begin
   if not FileExists(AFileName) then begin
      Result := False;
      exit;
   end
   else begin
      fillchar(pfromc,sizeof(pfromc),0) ;
      StrPcopy(pfromc,expandfilename(AFileName)+#0#0) ;
      Struct.wnd := 0;
      Struct.wFunc := FO_DELETE;
      Struct.pFrom := pFromC;
      Struct.pTo := nil;
      Struct.fFlags:= FOF_ALLOWUNDO or FOF_NOCONFIRMATION
         or FOF_SILENT;
      Struct.fAnyOperationsAborted := false;
      Struct.hNameMappings := nil;
      Resultval := ShFileOperation(Struct) ;
      Result := (Resultval = 0) ;
   end;
end;   //FileDeleteRB

I have put it into utilib.pas and call it from the deletion() procedure in main.pas

    procedure deletion();
    var
      i: integer;
      s: string;
    begin
    if (conn.request.method <> HM_POST)
    or (data.postVars.values['action'] <> 'delete')
    or not accountAllowed(FA_DELETE, conn, f) then exit;

    for i:=0 to data.postvars.count-1 do
      if sameText('selection', data.postvars.names) then
        begin
        s:=decodeURL(data.postvars.valueFromIndex);
        if ansiEndsStr('/', s) then setLength(s, length(s)-1); // folders' url
        if anycharIn('\/', s) then continue;
        s:=f.resource+'\'+s;
        if not FileDeleteRB(s) then
        if not moveToBin(s) then
        end;
    end; // deletion

When by mistake, a file destroyed from the web page does not disappear irreparably, but is moved in the recycle bin of Windows, and in case the recycle bin is full, then the file is definitively lost for everybody

 

[Mars]

add only this procedure in main.pas

...
 end // replace

function getAccountList():TstringDynArray;  //add by mars 22-nov-08
  var
  i: integer;
  s:string;
  begin
  if pars.count > 1 then
    begin
    for i:=0 to length(accounts)-1 do
      begin
      s:='';
      if (par(1)='all')
         or ((par(1)='groups') and accounts.group)
         or ((par(1)='users') and not accounts.group)
         then s:=accounts.user;
      if s > '' then
        begin
          setLength(result,Length(result)+1);
          result[Length(result)-1]:=s;
        end;
      end;
    end
    else
    begin
    setLength(result, length(accounts));
    for i:=0 to length(result)-1 do
    result:=accounts.user;
   end;
  end;

procedure dialog();
....

and you have access to those macros

{.get|accounts|all.}                    give all accounts  as {.get|accounts.}

{.get|accounts|groups.}              give only groups accounts list 

{.get|accounts|users.}                 give only users accounts  list

 

[Novox]

Hi rejetto,

I'm still seeing proxied IP not the x-forwarded-for

Request through Apache ReverseProxy

Thanks!

[Mars]

Novox, you have to put your screen shot as attached file in the post and not as a Web link, because the visual result is degraded there, convert it as png, size is little.

Here is the result of what we can see

It's true, but it makes many of click of mouse to obtain the result, while as now we obtain the same picture, and in more we can view how many persons visited the image, or directly the real link http://img114.imageshack.us/img114/6500/11111oi2.jpg

[sequestrum]

Well, actually Mars, you can follow the Imageshack link and click on the image there to see it in full size. You'll then see this: http://img114.imageshack.us/img114/6500/11111oi2.jpg

[Novox]

Thanks mars for your tip.

Anyway, in my problem, I have change the request to 127.0.0.1 but the IP is still in proxied.

[SilentPliz]

Hi!

Rejetto,

Think to update the file "upload_how.txt" in sources, for the next beta. 

[rejetto]

I'm still seeing proxied IP not the x-forwarded-for

right... it will be fixed in next beta.

[rejetto]

Think to update the file "upload_how.txt" in sources, for the next beta. 

whoops thanks for reporting

[wildmc]

i have problem on new build with big number of requests in parallel:
icon in taskbar disappears, program do not answer to my actions, very low performance
problem solved by rollback to 2.3.214

during working i have just one exception "Out of memory"

[chesus05]

Hi guys, I have a problem

Code:

Invalid floating point operation
HFS 2.3 beta (215)
----------------------------------------------------------------
Stack list, generated 24/11/2008 03:08:22 p.m.
[0040CD87]{hfs187.exe  } SysUtils.TryEncodeDate (Line 11649, "sysutils.pas" + 8) + $3F
[0040CDC2]{hfs187.exe  } SysUtils.EncodeDate (Line 11656, "sysutils.pas" + 1) + $10
[0040D097]{hfs187.exe  } SysUtils.Now (Line 11817, "sysutils.pas" + 2) + $C
[00404410]{hfs187.exe  } System.TObject.Free (Line 8849, "system.pas" + 1) + $4
[00556F83]{hfs187.exe  } main.TmainFrm.timerEvent (Line 7987, "main.pas" + 13) + $0
[0045AD17]{hfs187.exe  } ExtCtrls.TTimer.Timer (Line 2250, "ExtCtrls.pas" + 1) + $13
[0045AB83]{hfs187.exe  } ExtCtrls.TTimer.WndProc (Line 2208, "ExtCtrls.pas" + 4) + $7
[0042AC08]{hfs187.exe  } Classes.StdWndProc (Line 11572, "classes.pas" + 8) + $0
[0046C47C]{hfs187.exe  } Controls.FindControl (Line 2103, "Controls.pas" + 6) + $C
[00494E1E]{hfs187.exe  } Forms.TApplication.ProcessMessage (Line 7670, "Forms.pas" + 23) + $4
[00494E63]{hfs187.exe  } Forms.TApplication.HandleMessage (Line 7689, "Forms.pas" + 1) + $6
[004950FE]{hfs187.exe  } Forms.TApplication.Run (Line 7773, "Forms.pas" + 16) + $3
[0056A903]{hfs187.exe  } hfs.hfs (Line 97, "" + 21) + $2
----------------------------------------------------------------
System   : Windows XP Professional, Version: 5.1, Build: A28, "Service Pack 3"
Processor: Intel, Intel(R) Celeron(R) CPU          530  @ 1.73GHz, 1733 MHz MMX
Display  : 1280x800 pixels, 32 bpp
----------------------------------------------------------------
----------------------------------------------------------------
Product Versions

aStudio4b589.exe:12.0.0 Build: 58855 18/10/2008 06:39:10 p.m.
ccsetup212.exe:2.0.0 Build: 0 28/09/2008 04:53:44 p.m.
enmx_bg_keyboard_osd_10432311001251862.exe:1043.2.31 Build: 100 18/06/2008 10:06:34 p.m.
Firefox Setup 3.0.exe:4.42.0 Build: 0 17/06/2008 10:57:20 p.m.
GPU-Z.0.2.8.exe:0.2.8 Build: 0 17/11/2008 06:29:38 p.m.
hfs187.exe: Build: 0 24/11/2008 01:13:46 p.m.
PICSIM2.EXE: Build: 0 30/01/1997 03:33:20 p.m.
picsimulador.exe: Build: 0 26/06/2008 05:53:40 p.m.
resist.exe:1.0.0 Build: 0 06/08/2008 07:15:54 p.m.
SuperFlexibleSetup.exe:0.0.0 Build: 0 02/11/2008 06:33:36 p.m.
vbsetup.exe:2.0.50727 Build: 42 19/06/2008 10:41:04 p.m.
vcssetup.exe:2.0.50727 Build: 42 21/06/2008 10:36:06 p.m.
vlc-0.8.6h-win32.exe: Build: 0 18/06/2008 12:08:40 a.m.
xpiinstall.exe:6.0.100 Build: 33 27/10/2008 02:36:56 p.m.

   
apparently now well works

bye

IX

[rejetto]

during working i have just one exception "Out of memory"

this was with #214 or #215 ?

[Mars]

Not specific bug to this version, but appropriate for every build

 Renamean item in the vfs with an already existing name opens one dialog box asking for confirmation to duplicate this name, one NO answer entail all the same the modification

procedure TmainFrm.filesBoxEdited(Sender:TObject; Node:TTreeNode; var S:String);
var
  f: Tfile;
begin
f:=node.data;
if f.name = s then exit;

if existsNodeWithName(s, node.parent)
and (msgDlg(MSG_SAME_NAME, MB_ICONWARNING+MB_YESNO) <> IDYES) then exit;

// A  not valid filename  must be detected before a duplication of this name
if f.isFile() and not validFilename(s)
or (s = '')
or (pos('/',s) > 0)
then
  begin
  s:=node.text;             
  msgDlg('Invalid filename', MB_ICONERROR);
  exit;
  end;

if existsNodeWithName(s, node.parent)
and (msgDlg(MSG_SAME_NAME, MB_ICONWARNING+MB_YESNO) <> IDYES) then
  begin
  s:=node.text;    //add by mars
  exit;
  end;

f.name:=s;
VFSmodified:=TRUE;
updateUrlBox();
end;

And just to decorate this post
 

Do not cry, be happy!